This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Issue1838 #1842
Merged
Issue1838 #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlezhou
reviewed
Jul 4, 2018
| @@ -246,12 +246,12 @@ private void checkActionNames( | |||
| * @throws IOException | |||
| */ | |||
| private void checkActionsOnSubmit(CmdletInfo cmdletInfo, | |||
| List<ActionInfo> actionInfos) throws IOException { | |||
| List<ActionInfo> actionInfos) throws IOException { | |||
littlezhou
reviewed
Jul 4, 2018
| @@ -565,7 +564,7 @@ private ScheduleResult scheduleCmdletActions(CmdletInfo info, LaunchCmdlet launc | |||
| } | |||
|
|
|||
| private void postscheduleCmdletActions(List<Long> actions, ScheduleResult result, | |||
| int lastAction, int lastScheduler) { | |||
| int lastAction, int lastScheduler) { | |||
There was a problem hiding this comment.
Code alignment for functions followed
littlezhou
reviewed
Jul 4, 2018
| public ActionGroup searchAction(String path, long pageIndex, long numPerPage, | ||
| List<String> orderBy, List<Boolean> isDesc) throws IOException { | ||
| try { | ||
| LOG.info("[metaStore search] " + path); |
littlezhou
reviewed
Jul 4, 2018
| List<ActionInfo> infos = metaStore.searchAction(path, (pageIndex - 1) * numPerPage, | ||
| numPerPage, orderBy, isDesc); | ||
| for (ActionInfo info : infos) { | ||
| LOG.info("[metaStore search] " + info.getActionName()); |
littlezhou
reviewed
Jul 4, 2018
| } | ||
|
|
||
|
|
||
| public List<ActionInfo> searchAction(String path, long start, long offset) { |
There was a problem hiding this comment.
Merge with the upper function,
littlezhou
reviewed
Jul 4, 2018
| List<Boolean> desc) throws MetaStoreException { | ||
| try { | ||
| if (orderBy.size() == 0) { | ||
| return actionDao.searchAction(path, start, offset); |
There was a problem hiding this comment.
Call one function instead of two. The arguments can be handled in the function internally.
littlezhou
reviewed
Jul 4, 2018
| JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource); | ||
| boolean ifHasAid = false; | ||
| String sql = "SELECT * FROM " + TABLE_NAME + " WHERE (" | ||
| + "aid LIKE '%" + path + "%'" |
There was a problem hiding this comment.
Take care of special characters in SQL statement.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.