-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
@@ -246,12 +246,12 @@ private void checkActionNames( | |||
* @throws IOException | |||
*/ | |||
private void checkActionsOnSubmit(CmdletInfo cmdletInfo, | |||
List<ActionInfo> actionInfos) throws IOException { | |||
List<ActionInfo> actionInfos) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code alignment
@@ -565,7 +564,7 @@ private ScheduleResult scheduleCmdletActions(CmdletInfo info, LaunchCmdlet launc | |||
} | |||
|
|||
private void postscheduleCmdletActions(List<Long> actions, ScheduleResult result, | |||
int lastAction, int lastScheduler) { | |||
int lastAction, int lastScheduler) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code alignment for functions followed
public ActionGroup searchAction(String path, long pageIndex, long numPerPage, | ||
List<String> orderBy, List<Boolean> isDesc) throws IOException { | ||
try { | ||
LOG.info("[metaStore search] " + path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use debug level instead
List<ActionInfo> infos = metaStore.searchAction(path, (pageIndex - 1) * numPerPage, | ||
numPerPage, orderBy, isDesc); | ||
for (ActionInfo info : infos) { | ||
LOG.info("[metaStore search] " + info.getActionName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use debug level instead
} | ||
|
||
|
||
public List<ActionInfo> searchAction(String path, long start, long offset) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge with the upper function,
List<Boolean> desc) throws MetaStoreException { | ||
try { | ||
if (orderBy.size() == 0) { | ||
return actionDao.searchAction(path, start, offset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call one function instead of two. The arguments can be handled in the function internally.
JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource); | ||
boolean ifHasAid = false; | ||
String sql = "SELECT * FROM " + TABLE_NAME + " WHERE (" | ||
+ "aid LIKE '%" + path + "%'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take care of special characters in SQL statement.
|
No description provided.