Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Refine storage utilization page #2050

Merged
merged 24 commits into from
Apr 1, 2019
Merged

Conversation

archichen
Copy link
Collaborator

Change all tables to thumbnail. The larger table is shown when the user clicks on the thumbnail.

Thumbnails overview
thumbnails

Large table
lt1

Large table
lt2

@PHILO-HE
Copy link
Member

PHILO-HE commented Mar 5, 2019

image

@PHILO-HE
Copy link
Member

PHILO-HE commented Mar 5, 2019

1)In large figure, the usage value should not be shaded as the above picture shows.
2)Moving small figures to central position looks better.

@archichen
Copy link
Collaborator Author

1)In large figure, the usage value should not be shaded as the above picture shows.
2)Moving small figures to central position looks better.

I have fixed first problem. But the second problem, small figure may painted by NVD3. So I cant change the position of it without restructure NVD3 source code.

@archichen
Copy link
Collaborator Author

@PHILO-HE
Screenshot from 2019-03-11 16-25-02

@PHILO-HE
Copy link
Member

image

The java code style is not desirable. Set the code style as the picture shows in File/Settings/Editors/Code Style/Java and reformat the selecting code by clicking Code/Reformat the code.

@@ -0,0 +1,74 @@
package org.smartdata;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license declaration as same as other src files.


@GET
@Path("/all_server_hosts")
public Response allMasterHosts() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allServerHosts

@PHILO-HE
Copy link
Member

PHILO-HE commented Mar 14, 2019

src/index.html

[INFO] link rel="stylesheet" href="app/dashboard/views/cluster/nodeinfo/nodeStatus.css"
[INFO] ^ The empty tag : [ link ] must be self closed. (tag-self-close)
[INFO]
[INFO] >> 1 errors in 1 files
[INFO] Warning: Task "htmlhint:src" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.

@archichen
Copy link
Collaborator Author

@PHILO-HE I have fixed bug that open index page blank after compiled code. Also I have compiled source code and tested at local, work well.

@PHILO-HE PHILO-HE merged commit 5ca7804 into Intel-bigdata:trunk Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants