Conversion from raw to multi_ptr should be done with address_space_cast #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used `sycl::multi_ptr` constructor instead of `sycl::address_space_cast` previsously, and change in KhronosGroup/SYCL-Docs#432 introduced `sycl::access:decorated::legacy` as the default which is deprecated in SYCL 2020 standard which highlighted the problem. In using `sycl::address_space_cast` we specify `sycl::access::decorated::yes`.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1366/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_13 ran successfully. |
|
Even before this change, we should have been using now deprecated Merging. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_13 ran successfully. |
Merged
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used
sycl::multi_ptrconstructor instead ofsycl::address_space_castprevisously, and change in KhronosGroup/SYCL-Docs#432 introducedsycl::access:decorated::legacyas the default which is deprecated in SYCL 2020 standard which highlighted the problem.In using
sycl::address_space_castwe specifysycl::access::decorated::yes.