Tests to increase coverage of _clip.py #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1451/index.html |
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_51 ran successfully. |
ndgrigorian
approved these changes
Oct 23, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
ndgrigorian
pushed a commit
that referenced
this pull request
Oct 24, 2023
ndgrigorian
added a commit
that referenced
this pull request
Oct 24, 2023
ndgrigorian
added a commit
that referenced
this pull request
Oct 25, 2023
* Implements dpctl.tensor.clip * Clip now consistently yields max where max < min sycl::clamp would yield max or min depending on the platform A test has been added for this behavior * Adds more tests for clip * Removed redundant branches in clip and elementwise function calls As the result dtype of the out array is already checked when overlap is checked, checking again later is superfluous * Removed more redundant logic from clip * Fixed order logic in clip Now properly accounts for all three arrays in all branches * Adds more compute follows data tests for clip * Tests to increase coverage of _clip.py (#1451) * Clip raises ValueError when types cannot be resolved --------- Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two tests to improve coverage of
_clip.py.