Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves performance of search reductions for small numbers of elements #1464

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Improves performance of search reductions for small numbers of elements #1464

merged 2 commits into from
Nov 3, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Nov 3, 2023 •
edited by oleksandr-pavlyk
Loading

This pull request adds SequentialSearchReduction functor to improve argmax and argmin for small arrays.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1464/index.html

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_79 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@ndgrigorian
Adds SequentialSearchReduction functor to search reductions
5709f99
@ndgrigorian
Search reductions use correct branch for float16
119d43d 
constexpr branch logic accounted for floating point types but not sycl::half,
which meant NaNs were not propagating for float16 data
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_81 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the sequential-search-kernels branch from acd93ae to 119d43d Compare November 3, 2023 20:14
oleksandr-pavlyk
oleksandr-pavlyk approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ndgrigorian , thank you!

@ndgrigorian ndgrigorian merged commit af28d98 into optimize-small-size-tree-reduction Nov 3, 2023
14 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_83 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@ndgrigorian ndgrigorian deleted the sequential-search-kernels branch November 28, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndgrigorian @oleksandr-pavlyk