Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves gh-1439 #1477

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Resolves gh-1439 #1477

merged 1 commit into from
Dec 9, 2023

Conversation

ndgrigorian
Copy link
Collaborator

This pull request makes changes to sin and expm1 to properly treat real and complex -0 inputs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Resolves gh-1439
1c4b0ab 
Adjusts logic in expm1 and sin for negative 0s inputs in real and complex cases
@github-actions GitHub Actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1477/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.942%. remained the same
when pulling 1c4b0ab on resolve-gh-1439
into 5ec9fd5 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_18 ran successfully.
Passed: 874
Failed: 57
Skipped: 59

@ndgrigorian ndgrigorian marked this pull request as ready for review November 26, 2023 08:39
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_18 ran successfully.
Passed: 874
Failed: 57
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk merged commit ebf94b0 into master Dec 9, 2023
47 of 48 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the resolve-gh-1439 branch December 9, 2023 04:37
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk