Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_density for histogram #1115

Closed
wants to merge 3 commits into from
Closed

Fix test_density for histogram #1115

wants to merge 3 commits into from

Conversation

LukichevaPolina
Copy link
Contributor

No description provided.

Alexander-Makaryev
Alexander-Makaryev suggested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@Alexander-Makaryev Alexander-Makaryev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like dpnp.sum returns array instead scalar (as in original Numpy) and this is a reason why we have to change assert functions. Could you please check it and fix if it is so instead of using another functions?

@intel-python-devops
Copy link

Can one of the admins verify this patch?

@npolina4 npolina4 marked this pull request as draft February 20, 2024 16:45
@antonwolfy
Copy link
Contributor

#1785 covers that PR

@antonwolfy antonwolfy closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@densmirn densmirn densmirn approved these changes

@Alexander-Makaryev Alexander-Makaryev Awaiting requested review from Alexander-Makaryev

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy will be requested when the pull request is marked ready for review antonwolfy is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 will be requested when the pull request is marked ready for review npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev will be requested when the pull request is marked ready for review vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana will be requested when the pull request is marked ready for review vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LukichevaPolina @intel-python-devops @antonwolfy @Alexander-Makaryev @densmirn