Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse dpctl.tensor.place for dpnp.place #1337

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Reuse dpctl.tensor.place for dpnp.place #1337

merged 5 commits into from
Mar 20, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR modifies dpnp.place() implementation to use dpctl.tensor.place() instead of dpnp implementation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Mar 13, 2023
antonwolfy
antonwolfy reviewed Mar 14, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_algo_indexing.pyx Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Mar 16, 2023
View reviewed changes
tests/test_indexing.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev merged commit 4de4ef9 into IntelPython:master Mar 20, 2023
antonwolfy pushed a commit that referenced this pull request Jun 6, 2023
@vlad-perevezentsev @antonwolfy
Reuse dpctl.tensor.place for dpnp.place (#1337)
143e3c9 
* Reuse dpctl.tensor.place for dpnp.place

* Remove unused declaration and usefixtures
@vlad-perevezentsev vlad-perevezentsev deleted the reuse_dpctl_place branch August 10, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy