Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed included dpnp_algo_*.pyx files to *.pxi #1356

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Renamed included dpnp_algo_*.pyx files to *.pxi #1356

merged 1 commit into from
Apr 3, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR renames dpnp/dpnp_algo/dpnp_algo_*.pyx files that are included into dpnp/dpnp_algo/dpnp_algo.pyx to have *.pxi extensions.

This should improve behavior of Cython coverage plugin which treats files differently based on their filename extension.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

antonwolfy
antonwolfy approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-pavlyk !

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review April 2, 2023 16:50
@oleksandr-pavlyk oleksandr-pavlyk merged commit b536ae9 into use-skbuild-and-cmake Apr 3, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the rename-included-pyx-to-pxi branch April 3, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @antonwolfy