using rowvar keyword in dpnp.cov #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
force-pushed
the
add_rowvar_to_cov
branch
from
eb6c4b5 to
11d596f
Compare
vtavana
force-pushed
the
add_rowvar_to_cov
branch
2 times, most recently
from
16240a1 to
bdd40da
Compare
vtavana
changed the title
vtavana
force-pushed
the
add_rowvar_to_cov
branch
from
bdd40da to
7b3b992
Compare
antonwolfy
reviewed
Apr 7, 2023
vtavana
force-pushed
the
add_rowvar_to_cov
branch
from
7b3b992 to
5d837b1
Compare
antonwolfy
reviewed
Apr 12, 2023
vtavana
force-pushed
the
add_rowvar_to_cov
branch
from
5d837b1 to
4e04716
Compare
| if not rowvar and x1.shape[0] != 1: | ||
| x1 = x1.get_array() if isinstance(x1, dpnp_array) else x1 | ||
| x1 = dpnp_array._create_from_usm_ndarray(x1.mT) | ||
| x1 = dpnp.astype(x1, dpnp.float64) if x1_desc.dtype != dpnp.float64 else x1 |
There was a problem hiding this comment.
Please test that this works on Iris Xe, or other devices that do not support float64 data type.
There was a problem hiding this comment.
It will not work. @antonwolfy mentioned it is written like this because Numpy by default returns float64 for any input data type. The suggestion was to fix it in a separate ticket since it needs to correct dpnp c++ backend code.
There was a problem hiding this comment.
I've filed #1379 to add support of dpnp.cov on Iris Xe
| x1 = dpnp.astype(x1, dpnp.float64) if x1_desc.dtype != dpnp.float64 else x1 | ||
| x1_desc = dpnp.get_dpnp_descriptor(x1, copy_when_nondefault_queue=False) | ||
| elif x1_desc.dtype != dpnp.float64: | ||
| x1 = dpnp.astype(x1, dpnp.float64) |
There was a problem hiding this comment.
Same comment here
vtavana
force-pushed
the
add_rowvar_to_cov
branch
from
4e04716 to
93bb5e7
Compare
vtavana
force-pushed
the
add_rowvar_to_cov
branch
from
93bb5e7 to
d7c3dc8
Compare
antonwolfy
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1367
rowvarkeyword is added todpnp.covfunctiondpnp.dpnp_array.dpnp_array._create_from_usm_ndarray(x.get_array().mT)is used since it is faster thandpnp.transpose(x)since dpnp.tarnsport%timeit dpnp.cov(dpnp.dpnp_array.dpnp_array._create_from_usm_ndarray(x.get_array().mT))5.4 ms ± 121 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
%timeit dpnp.cov(dpnp.transpose(x))9.46 ms ± 455 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
%timeit dpnp.cov(x, rowvar=False)5.49 ms ± 352 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)