-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dpnp.linalg.eigh() function #1383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
oleksandr-pavlyk,
vlad-perevezentsev,
npolina4 and
vtavana
April 19, 2023 13:01
antonwolfy
force-pushed
the
add_linalg_eigh
branch
7 times, most recently
from
April 20, 2023 17:31
1950d5b
to
547f5b3
Compare
antonwolfy
force-pushed
the
add_linalg_eigh
branch
from
April 20, 2023 17:54
547f5b3
to
57b92e2
Compare
6 tasks
npolina4
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in pca workload. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is about to close #1344, since it covers the last functional gap of
pca
benchmark.PR adds a missing
dpnp.linalg.eigh()
function to calculate the eigenvalues and eigenvectors of a complex Hermitian (conjugate symmetric) or a real symmetric input matrix. OneMKL LAPACK library is used for that.The implementation is written as a pybind11 extension above required LAPACK functions.
This is a base PR which assumes to be extended later with remaining functions from OneMKL LAPACK library, once new functionality required.
Numbers for a laptop with Iris Xe: