Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hooks #1448

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Add pre-commit hooks #1448

merged 2 commits into from
Jun 19, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 19, 2023 •
edited
Loading

The PR implements the following pre-commit hooks:

  • check-ast
  • check-builtin-literals
  • check-case-conflict
  • check-executables-have-shebangs
  • check-merge-conflict
  • check-shebang-scripts-are-executable
  • check-toml
  • debug-statements
  • destroyed-symlinks
  • double-quote-string-fixer
  • end-of-file-fixer
  • fix-byte-order-marker
  • mixed-line-ending
  • trailing-whitespace

All identified issues are resolved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jun 19, 2023
vlad-perevezentsev
vlad-perevezentsev approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @antonwolfy

@antonwolfy antonwolfy merged commit b0cd5f8 into master Jun 19, 2023
22 checks passed
@antonwolfy antonwolfy deleted the add_pre_commit_hook branch June 19, 2023 21:43
@antonwolfy antonwolfy mentioned this pull request Jul 13, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev