Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp.power using dpctl and OneMKL implementations #1476

Merged
merged 25 commits into from
Aug 29, 2023
Merged

Update dpnp.power using dpctl and OneMKL implementations #1476

merged 25 commits into from
Aug 29, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds the ability to rely on dpctl.tensor.pow() implementation for dpnp.power function and call pow from pybind11 extension of OneMKL if possible

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 13, 2023
antonwolfy
antonwolfy reviewed Jul 13, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_algo.pxd Show resolved Hide resolved
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
tests/test_mathematical.py Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_arithmetic.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @vlad-perevezentsev

dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 27, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/third_party/cupy/testing/helper.py Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_arithmetic.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you @vlad-perevezentsev

@vlad-perevezentsev
Copy link
Collaborator Author

I have investigated CI falling for windows validation.
These falls are false-positives , are not related to my changes and will be fixed in Jenkins.
So I will merge this PR

@vlad-perevezentsev vlad-perevezentsev merged commit fa3cd55 into IntelPython:master Aug 29, 2023
31 of 34 checks passed
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy