-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specialized kernel for sum(axis=0) as extension #1479
Merged
antonwolfy
merged 3 commits into
IntelPython:master
from
AlexanderKalistratov:specialize_sum_mean_axis0_kernel
Jul 18, 2023
Merged
Add specialized kernel for sum(axis=0) as extension #1479
antonwolfy
merged 3 commits into
IntelPython:master
from
AlexanderKalistratov:specialize_sum_mean_axis0_kernel
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AlexanderKalistratov
commented
Jul 17, 2023
•
edited
Loading
edited
- Have you provided a meaningful PR description?
- Have you added a test, reproducer or referred to issue with a reproducer?
- Have you tested your changes locally for CPU and GPU devices?
- Have you made sure that new changes do not introduce compiler warnings?
- Have you checked performance impact of proposed changes?
- If this PR is a work in progress, are you filing the PR as a draft?
import dpnp
import time
a = dpnp.ones((262144, 128), device="gpu")
dpnp.sum(a, axis=1)
start = time.time()
dpnp.sum(a, axis=1)
print(time.time() - start)
dpnp.sum(a, axis=0)
start = time.time()
dpnp.sum(a, axis=0)
print(time.time() - start) Before patch:
After patch:
|
AlexanderKalistratov
force-pushed
the
specialize_sum_mean_axis0_kernel
branch
from
July 17, 2023 17:30
0b4e9c8
to
642ec20
Compare
AlexanderKalistratov
force-pushed
the
specialize_sum_mean_axis0_kernel
branch
2 times, most recently
from
July 17, 2023 19:06
7d0b294
to
a92812d
Compare
antonwolfy
reviewed
Jul 17, 2023
antonwolfy
reviewed
Jul 17, 2023
AlexanderKalistratov
force-pushed
the
specialize_sum_mean_axis0_kernel
branch
from
July 17, 2023 22:23
f308214
to
6ea51e7
Compare
AlexanderKalistratov
force-pushed
the
specialize_sum_mean_axis0_kernel
branch
from
July 17, 2023 22:26
6ea51e7
to
1e03e27
Compare
AlexanderKalistratov
force-pushed
the
specialize_sum_mean_axis0_kernel
branch
from
July 17, 2023 22:30
1e03e27
to
24df081
Compare
antonwolfy
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.