Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Pointer to local outside scope issue reported by Coverity tool #1514

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Resolve Pointer to local outside scope issue reported by Coverity tool #1514

merged 2 commits into from
Aug 8, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 7, 2023 •
edited
Loading

The PR proposes to resolve faulty access to a local variable outside the scope.

Note, the issue was identified by Coverity tool and classified as of high severity.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@antonwolfy antonwolfy merged commit dd7a6ea into master Aug 8, 2023
25 of 26 checks passed
@antonwolfy antonwolfy deleted the pointer_to_local_outside_scope branch August 8, 2023 10:28
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @oleksandr-pavlyk