Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_dpctl_conj_for_dpnp #1519

Merged
merged 4 commits into from
Aug 19, 2023
Merged

use_dpctl_conj_for_dpnp #1519

merged 4 commits into from
Aug 19, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 11, 2023 •
edited
Loading

The PR changes the implementation of dpnp.conjugate and its alias dpnp.conj. These functions now invoke oneapi::mkl::vm::conj from pybind11 extension of OneMKL VM if possible or uses dpctl.tensor.conj implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the use_dpctl_conj_in_dpnp branch 2 times, most recently from 5325018 to 3cba1ce Compare August 16, 2023 17:37
@vtavana vtavana marked this pull request as ready for review August 16, 2023 17:37
antonwolfy
antonwolfy reviewed Aug 18, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
tests/test_usm_type.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the use_dpctl_conj_in_dpnp branch 2 times, most recently from ed2815d to ffa8c92 Compare August 18, 2023 18:50
antonwolfy
antonwolfy approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana LGTM!

@vtavana vtavana force-pushed the use_dpctl_conj_in_dpnp branch 2 times, most recently from 83e72a1 to 653ce2e Compare August 19, 2023 02:40
@vtavana vtavana merged commit ab97cf3 into master Aug 19, 2023
26 of 39 checks passed
@vtavana vtavana deleted the use_dpctl_conj_in_dpnp branch August 19, 2023 03:34
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 19, 2023
Closed
Merged
@antonwolfy antonwolfy mentioned this pull request May 31, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy