Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp fft implementations to run on Iris Xe #1524

Merged
merged 12 commits into from
Aug 21, 2023
Merged

Update dpnp fft implementations to run on Iris Xe #1524

merged 12 commits into from
Aug 21, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests expanding type mapping for fft kernels and calling them when running on Iris Xe without support for double-precision types.
Additionally updates the docstrings and tests for all fft functions

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 17, 2023
View reviewed changes
dpnp/backend/kernels/dpnp_krnl_fft.cpp Outdated Show resolved Hide resolved
dpnp/backend/kernels/dpnp_krnl_fft.cpp Outdated Show resolved Hide resolved
dpnp/fft/dpnp_iface_fft.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev LGTM!

@antonwolfy antonwolfy merged commit a717c69 into master Aug 21, 2023
@antonwolfy antonwolfy deleted the fix_fft_iris branch August 21, 2023 12:30
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy