Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dpnp.allclose() for a device without fp64 aspect #1536

Merged
merged 10 commits into from
Aug 28, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 24, 2023

The PR proposes to provide support of dpnp.allclose function for a device without fp64 aspect.
Additionally, use cases with nan and inf values in input arrays are handling properly now.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the allclose_no_fp64 branch 2 times, most recently from ca7a676 to f518ead Compare August 25, 2023 16:39
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!
thank you @antonwolfy

@antonwolfy antonwolfy merged commit 0fd57d4 into master Aug 28, 2023
21 checks passed
@antonwolfy antonwolfy deleted the allclose_no_fp64 branch August 28, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants