Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented dpnp.hstack() and dpnp.atleast_1d() functions. #1544

Merged
merged 10 commits into from
Sep 6, 2023
Merged

Implemented dpnp.hstack() and dpnp.atleast_1d() functions. #1544

merged 10 commits into from
Sep 6, 2023

Conversation

npolina4
Copy link
Collaborator

Implemented dpnp.hstack() and dpnp.atleast_1d() functions.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 28, 2023
View reviewed changes
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
tests/test_arraymanipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/test_arraymanipulation.py Show resolved Hide resolved
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 31, 2023
View reviewed changes
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coverage of dpnp/dpnp_iface_manipulation.py is decreased by 1.18 %

dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@antonwolfy antonwolfy merged commit 80eb738 into master Sep 6, 2023
21 checks passed
@antonwolfy antonwolfy deleted the implement_hstack branch September 6, 2023 20:53
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy