Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement maximum and minimum #1558

Merged
merged 5 commits into from
Sep 29, 2023
Merged

implement maximum and minimum #1558

merged 5 commits into from
Sep 29, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 13, 2023

In this PR, we re-write dpnp.maximum and dpnp.minimum using their counterpart in dpctl, i.e., dpctl.tensor.maximum and dpctl.tensor.minimum. These functions propagate NaNs.

Old implementation is kept to use for dpnp.fmin and dpnp.fmax which have the same functionality except they ignore NaNs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review September 13, 2023 21:07
vlad-perevezentsev
vlad-perevezentsev reviewed Sep 15, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Show resolved Hide resolved
tests/test_usm_type.py Show resolved Hide resolved
@vtavana vtavana force-pushed the minimum_maximum_dpctl_to_dpnp branch from f586982 to c80e404 Compare September 25, 2023 16:21
vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thank you @vtavana

@vtavana vtavana merged commit e3be611 into master Sep 29, 2023
34 checks passed
@vtavana vtavana deleted the minimum_maximum_dpctl_to_dpnp branch September 29, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @vlad-perevezentsev