Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-write dpnp.hypot #1560

Merged
merged 3 commits into from
Sep 29, 2023
Merged

re-write dpnp.hypot #1560

merged 3 commits into from
Sep 29, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 17, 2023

The PR changes the implementation of dpnp.hypot. This function now invokes oneapi::mkl::vm implementation from pybind11 extension of OneMKL VM if possible or uses dpctl.tensor.hypot implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review September 17, 2023 20:07
@vtavana vtavana force-pushed the hypot_dpctl_to_dpnp branch from ab34319 to 2f5e79b Compare September 21, 2023 17:59
@vtavana vtavana force-pushed the hypot_dpctl_to_dpnp branch from 2f5e79b to 29246d1 Compare September 29, 2023 15:38
vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @vtavana

@vtavana vtavana merged commit 946ff08 into master Sep 29, 2023
21 checks passed
@vtavana vtavana deleted the hypot_dpctl_to_dpnp branch September 29, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @vlad-perevezentsev