Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage dpctl.tensor.iinfo() and dpctl.tensor.finfo() implementation. #1582

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Leverage dpctl.tensor.iinfo() and dpctl.tensor.finfo() implementation. #1582

merged 4 commits into from
Oct 11, 2023

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Oct 10, 2023 •
edited
Loading

Leverage dpctl.tensor.iinfo() and dpctl.tensor.finfo() implementation.
The usage of the numpy.iinfo and numpy.finfo functions has been changed to dpnp.iinfo and dpnp.finfo.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Oct 10, 2023
View reviewed changes
dpnp/dpnp_iface_types.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_types.py Show resolved Hide resolved
dpnp/dpnp_iface_types.py Outdated Show resolved Hide resolved
@npolina4 npolina4 mentioned this pull request Oct 10, 2023
Closed
5 tasks
antonwolfy
antonwolfy approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@antonwolfy antonwolfy merged commit 0fe9a00 into master Oct 11, 2023
34 checks passed
@antonwolfy antonwolfy deleted the iinfo_finfo branch October 11, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy