Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in place divide and floor_divide #1587

Merged
merged 4 commits into from
Nov 13, 2023
Merged

in place divide and floor_divide #1587

merged 4 commits into from
Nov 13, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 11, 2023 •
edited
Loading

Dedicated kernels are implemented in dpctl for in-place division and floor division #1431

In this PR, this feature is added for dpnp.divide and dpnp.floor_divide.
New tests are written for them.

UPDATE:
With recent updates in dpctl (#1463), the usage of in-place operator are automatically incorporated in dpnp. This PR now only updates the relevant tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review October 11, 2023 04:48
@vtavana vtavana requested a review from antonwolfy October 11, 2023 04:48
antonwolfy
antonwolfy reviewed Oct 11, 2023
View reviewed changes
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the divide_in_place branch 4 times, most recently from 8b1656e to 1a58867 Compare October 12, 2023 20:15
antonwolfy
antonwolfy approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

tests/test_mathematical.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the divide_in_place branch 2 times, most recently from 106537e to 88c113d Compare November 8, 2023 04:44
@vtavana vtavana merged commit c31557c into master Nov 13, 2023
39 of 42 checks passed
@vtavana vtavana deleted the divide_in_place branch November 13, 2023 20:18
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @ndgrigorian @antonwolfy