-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require dpcpp compiler 2024.0 and runtime >=2024.0 #1625
Conversation
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Not sure if it is possible for dpnp or not, but dpctl is flexible on dependencies to allow both
Currently environment resolution results in broken environment with latest (dpcpp-rt) because dpctl on intel channel allows latest dpcpp-rt on dpnp=0.13.0 and it is incompatible with latest dpctl due to missing attribute:
|
4986177
to
c1260cc
Compare
c89f2f4
to
cc8cb2c
Compare
cc8cb2c
to
ea821b9
Compare
The PR pins DPC++ compiler and MKL version to the latest release.
Additionally a dependency on dpctl version is stepped due to changed interface in dpctl for elementwise functions.
While a dependency on dpctl version in run section is rewritten to use
pin_compatible
construction, but to result into the same expression as before:dpctl >={{ required_dpctl_version }}
Note1: coverage report can be collected only with DPC++ 2023.2 for now due to known compiler issue. It means dpnp needs to keep backward compatibility with
dpctl=0.15.0
(later dpctl packages require DPC++ 2024.0).To archive this dpctl needs to be installed from
dppy/label/coverage
channel, which has the latest dpctl content and was built with DPC++ 2023.2 compiler.Once the issue will be resolved, it is proposed to removed the workaround and to switch back to use of
dppy/label/dev
channel.Note2: the latest dpctl changes resolves wrong power result on Windows for complex types, previously it was:
Now the result is the same for both Linux and Windows and fully aligned with numpy. But since the latest dpctl isn't available on internal channel yet, the test is muted for Windows platform and has to be unmuted once the newer dpctl is available. Thus the
TODO
comment left in code to point that.Note3: the PR partly covers the changes from #1623.