Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy step of a job with building docs #1631

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 27, 2023

The PR closes #1620 issues.
The PR closes #1621 pull request as superseded.

A step Deploy docs from building docs actions was indented to only build dpnp docs when the new commit is pushed to "master" branch. But due to wrong conditions the step was triggered from pull request of PR branch when event comes with action="closed" property.

Another major issue is missing keep_files option enabled for the step, which leads to removal of all files from "gh-pages" branch (as a pre-step), i.e. also including generated doc files relating to another PRs (located in a special "pull" folder and which has to be removed by separate Clean job per each closing PR).

The PR assumes to resolve both above issues.
Additionally GitHub bot user and email is used to push on "gh-pages" branch facelessly.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 27, 2023
Copy link
Contributor

github-actions bot commented Nov 27, 2023

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 912bb77 into master Nov 28, 2023
30 of 39 checks passed
@antonwolfy antonwolfy deleted the resolve_gh_1620 branch November 28, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy docs job deletes all pull request docs
2 participants