Add type checking in assert_dtype_allclose for inexact dtypes
#1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
antonwolfy
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Thank you @vlad-perevezentsev for the suggested improvement!
vtavana
reviewed
Dec 1, 2023
antonwolfy
reviewed
Dec 4, 2023
vlad-perevezentsev
force-pushed
the
fix_helper_func
branch
from
d15b934 to
e0b6f0e
Compare
antonwolfy
approved these changes
Dec 5, 2023
github-actions bot
added a commit
that referenced
this pull request
Dec 5, 2023
* Add dtype checking for inexact dtype in assert_dtype_allclose * Update test_out_dtypes in TestDivide * Add a check for support of 16 bit types * Add an empty line after the description * fix condition when numpy`s array is not float16 * Address the remarks * Update test_sum_float in test_sum.py * Add a new check_only_type_kind param to assert_dtype_allclose * Update test_sum and test_fft * Use check_only_type_kind in test_fft_rfft 2c8cbb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
assert_dtype_allclosefunction by adding type checking for cases with inexact data types.It makes the behaviour of the function consistent with its purpose and improves the reliability of data type checking in
dpnpfunctions.