Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impelment dpnp.std, dpnp.var and dpnp.nanvar #1635

Merged
merged 15 commits into from
Dec 16, 2023
Merged

impelment dpnp.std, dpnp.var and dpnp.nanvar #1635

merged 15 commits into from
Dec 16, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Dec 4, 2023 •
edited
Loading

In this PR,

  1. dpnp.std and dpnp.var are implemented using their dpctl counterparts.
  2. dpnp.nanvar is implemented using existing functions in dpnp.
  3. support of out keyword is added for dpnp.sum.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Dec 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as ready for review December 5, 2023 23:47
@vtavana vtavana changed the title impelment dpnp.var and dpnp.std impelment dpnp.std, dpnp.var and dpnp.nanvar Dec 5, 2023
antonwolfy
antonwolfy reviewed Dec 8, 2023
View reviewed changes
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
tests/skipped_tests.tbl Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Dec 13, 2023
View reviewed changes
tests/third_party/cupy/math_tests/test_sumprod.py Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Dec 14, 2023
View reviewed changes
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_statistics.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana ! Great job!

@antonwolfy antonwolfy merged commit 996cf54 into master Dec 16, 2023
40 of 45 checks passed
@antonwolfy antonwolfy deleted the std_var branch December 16, 2023 11:24
github-actions bot added a commit that referenced this pull request Dec 16, 2023
@github-actions
impelment dpnp.std, dpnp.var and dpnp.nanvar (#1635)
89f7f5d 
* impelment dpnp.var and dpnp.std

* implement dpnp.nanvar

* support out keyword for dpnp.sum

* add more tests

* use replace_nan func for nanprod

* address comments

* update test_sum_empty_axis

* address new comments

* minor update

* address remarks

* remove uncalled raise 996cf54
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy