Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrying build coverage step on failure #1640

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Retrying build coverage step on failure #1640

merged 5 commits into from
Dec 12, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 11, 2023 •
edited
Loading

The step with building coverage is failing quite often due to known issue with OCL RT.
The PR propose to automatically rerun the step multiple times until the issue is resolved and a fix is available.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 11, 2023
@antonwolfy antonwolfy force-pushed the retry_on_failure branch 2 times, most recently from f222896 to f1255b3 Compare December 11, 2023 12:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review December 12, 2023 14:11
@antonwolfy antonwolfy requested review from vtavana and vlad-perevezentsev and removed request for vtavana December 12, 2023 14:11
vlad-perevezentsev
vlad-perevezentsev approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very useful change
LGTM!
Many thanks @antonwolfy

@antonwolfy antonwolfy merged commit 28d3348 into master Dec 12, 2023
45 checks passed
@antonwolfy antonwolfy deleted the retry_on_failure branch December 12, 2023 15:38
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev