Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stay away from 2024.0.1 compiler package #1643

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Stay away from 2024.0.1 compiler package #1643

merged 2 commits into from
Dec 12, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 12, 2023 •
edited
Loading

The compiler package dpcpp_linux-64=2024.0.1 has known issues breaking CMake integration with DPC++.
This PR pins build-time version to 2024.0.0 until the underlying issue gets resolved.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 4f3b2de into master Dec 12, 2023
42 of 45 checks passed
@antonwolfy antonwolfy deleted the pin_cmpl_conda_pkg branch December 12, 2023 13:40
github-actions bot added a commit that referenced this pull request Dec 12, 2023
@github-actions
Stay away from 2024.0.1 compiler package (#1643)
bd05d73 
* Stay away from 2024.0.1 compiler package

* Limit max compiler version while building docs 4f3b2de
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Dec 12, 2023
@github-actions
Stay away from 2024.0.1 compiler package (IntelPython#1643)
6c71ac2 
* Stay away from 2024.0.1 compiler package

* Limit max compiler version while building docs 4f3b2de
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
@antonwolfy antonwolfy mentioned this pull request Mar 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev