Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanmin #1646

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Dec 18, 2023

In this PR, dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanmin are implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Dec 18, 2023
Copy link
Contributor

github-actions bot commented Dec 18, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review December 18, 2023 20:27
@vtavana vtavana requested a review from antonwolfy December 18, 2023 20:27
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Show resolved Hide resolved
tests/test_statistics.py Outdated Show resolved Hide resolved
tests/third_party/cupy/sorting_tests/test_search.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_order.py Outdated Show resolved Hide resolved
@vtavana vtavana changed the title implement nanargmax, nanargmin, nanmax, and nanmin implement dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanmin Dec 20, 2023
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana , LGTM!

@vtavana vtavana merged commit 680d903 into master Dec 20, 2023
44 of 45 checks passed
@vtavana vtavana deleted the nanargmax_nanargmin branch December 20, 2023 17:14
github-actions bot added a commit that referenced this pull request Dec 20, 2023
…p.nanmin` (#1646)

* implement nanargmax, nanargmin, nanmax, nanmin

* address comments

* suppress overflow warning 680d903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants