Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum, and dpnp.average #1654

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 9, 2024

In this PR, dpnp.nanmean, dpnp.nanstd, dpnp.nansum, and dpnp.average are implemented using existing functions in dpnp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review January 10, 2024 04:24
dpnp/dpnp_algo/dpnp_algo_mathematical.pxi Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Show resolved Hide resolved
dpnp/dpnp_iface_nanfunctions.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_statistics.py Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_sumprod.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_sumprod.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana LGTM!

tests/test_mathematical.py Outdated Show resolved Hide resolved
@antonwolfy antonwolfy merged commit 3fdb921 into master Jan 12, 2024
43 of 45 checks passed
@antonwolfy antonwolfy deleted the nanmean_nanstd_nansum_average branch January 12, 2024 13:33
github-actions bot added a commit that referenced this pull request Jan 12, 2024
…rage` (#1654)

* implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum and dpnp.average

* change size huge test case

* fix TestArithmetic test

* fix test nanmean

* address comments

* using assert_dtype_allclose

* add rtol to comparison

* Update tests/test_mathematical.py

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 3fdb921
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Jan 12, 2024
…rage` (IntelPython#1654)

* implement dpnp.nanmean, dpnp.nanstd, dpnp.nansum and dpnp.average

* change size huge test case

* fix TestArithmetic test

* fix test nanmean

* address comments

* using assert_dtype_allclose

* add rtol to comparison

* Update tests/test_mathematical.py

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 3fdb921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants