Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipping with both min and max values as None #1670

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Clipping with both min and max values as None #1670

merged 1 commit into from
Jan 26, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 26, 2024 •
edited
Loading

Dpctl implemented clip function according to Python array API specification. And dpnp fully relies on dpctl.tensor.clip implementation.
While NumPy requires that only one of min or max be allowed to be None at the same time.

The PR proposes to align dpnp.clip with both min and max as None with NumPy implementation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

vtavana
vtavana approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

vlad-perevezentsev
vlad-perevezentsev approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit a75e599 into master Jan 26, 2024
44 of 45 checks passed
@antonwolfy antonwolfy deleted the clip_none_both_min_max branch January 26, 2024 16:23
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @vlad-perevezentsev @vtavana