Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for array creation functions #1674

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Update docs for array creation functions #1674

merged 7 commits into from
Feb 5, 2024

Conversation

npolina4
Copy link
Collaborator

Update docs for array creation functions:

  • Added Parameters section
  • Added missing Return section
  • Added CFD examples
  • Minor fix other examples

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana reviewed Feb 1, 2024
View reviewed changes
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
vtavana
vtavana reviewed Feb 2, 2024
View reviewed changes
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
vtavana
vtavana approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @npolina4!

@npolina4 npolina4 merged commit 554bcdd into master Feb 5, 2024
44 of 46 checks passed
@npolina4 npolina4 deleted the creation_funcs_docs branch February 5, 2024 23:46
github-actions bot added a commit that referenced this pull request Feb 6, 2024
@github-actions
Update docs for array creation functions (#1674)
2ef767c 
* Update docs for array creation functions

* fix pre-cimmit

* address comments

* address comments

* Add CFD examples and update CFD check for dpnp.copy

* Fix dpnp.asfortranarray and dpnp.ascontiguousarray functions for not array input (#1691)

* Fix dpnp.asfortranarray and dpnp.ascontiguousarray functions for not array input

* Fix tests 554bcdd
@antonwolfy antonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npolina4 @antonwolfy @vtavana