Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raises NotImplementedError for array creation functions #1695

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Add raises NotImplementedError for array creation functions #1695

merged 6 commits into from
Feb 13, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Feb 6, 2024

Add raises NotImplementedError for array creation functions
Update dpnp.tri, dpnp.tril, and dpnp.triu implementation and errors
Add tests

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Feb 6, 2024
View reviewed changes
tests/skipped_tests.tbl Outdated Show resolved Hide resolved
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Feb 7, 2024
View reviewed changes
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4

@antonwolfy antonwolfy merged commit 4f4db77 into master Feb 13, 2024
45 checks passed
@antonwolfy antonwolfy deleted the not_implemented_error branch February 13, 2024 09:11
github-actions bot added a commit that referenced this pull request Feb 13, 2024
@github-actions
Add raises NotImplementedError for array creation functions (#1695)
d000f4b 
* Add raises NotImplementedError for array creation functions

* address comments

* address comments

* Added value error for order A and K. Changed test for exceptions

* Fix pre-commit 4f4db77
antonwolfy added a commit that referenced this pull request Feb 15, 2024
@antonwolfy
Added #1699, #1690 and #1695
f47d935
antonwolfy added a commit that referenced this pull request Feb 15, 2024
@antonwolfy
Preparation for 0.14.0rc1 tag (#1711)
b95b89c 
* Added #1699, #1690 and #1695

* Stepped dpctl version in all dependencies
@antonwolfy antonwolfy mentioned this pull request Feb 15, 2024
Merged
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 15, 2024
@github-actions
Preparation for 0.14.0rc1 tag (IntelPython#1711)
ced5ae9 
* Added IntelPython#1699, IntelPython#1690 and IntelPython#1695

* Stepped dpctl version in all dependencies b95b89c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy