Fix ExecutionPlacementError for dpnp.take_along_axis #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Thank you @vlad-perevezentsev for catching and resolving this
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
github-actions bot
added a commit
that referenced
this pull request
Feb 9, 2024
* Follow compute follows data to fill fancy_index * Update take_along_axis tests to cover the issue * Update test_take_along_axis 4c7859b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue of raising
ExecutionPlacementErrorwhen usingdpnp.take_along_axis()with 2D arrays andaxis not NoneFilling
fancy_indexin_build_along_axis_indexdid not follow compute follows data and allocated dpnp index arrays on the device and queues by default.Also this case was not covered in the tests so I extended them.