Add dpnp.linalg.pinv() implementation #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Feb 10, 2024
antonwolfy
reviewed
Feb 12, 2024
There was a problem hiding this comment.
Due to some reason there are changes from other PRs on the branch, hard to review. Btw, I don't have more comments. Thank you @vlad-perevezentsev !
vlad-perevezentsev
force-pushed
the
impl_pinv
branch
from
9cda6f6
to
826610b
Compare
antonwolfy
reviewed
Feb 12, 2024
antonwolfy
approved these changes
Feb 15, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 16, 2024
* Impl dpnp.linalg.pinv() * Add cupy tests for dpnp.linalg.pinv() * Add tests to test_sycl_queue and test_usm_type * Add TestPinv to test_linalg.py * Add additional checks for rcond parameter * Add a more efficient implementation * Use numpy.random.seed in test_linalg * Use setup_method to ruduce code duplication in test_linalg * Change the seed number * Use numpy.random.seed in test_usm_type and test_sycl_queue --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 2c38ae8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
dpnp.linalg.pinv()function to calculate the (Moore-Penrose) pseudo-inverse of input arrray usingdpnp.linalg.svd()anddpnp.matmul()The changes are related to support of all types and support of function arguments as
hermitian