Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented dpnp.fromfunction, dpnp.fromiter and dpnp.loadtxt #1728

Merged
merged 13 commits into from
Feb 25, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 22, 2024

This PR add implementation of dpnp.fromfunction, dpnp.fromiter and dpnp.loadtxt to complete all array creation function we are going to support for DPNP.
Additionally the doc page is slightly updated to align with NumPy description.

The PR is about to close #1229.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 22, 2024
Copy link
Contributor

github-actions bot commented Feb 22, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
dpnp/dpnp_iface_arraycreation.py Show resolved Hide resolved
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit fc317cb into master Feb 25, 2024
45 checks passed
@antonwolfy antonwolfy deleted the from_like_functions branch February 25, 2024 16:20
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 25, 2024
…ython#1728)

* Implemented dpnp.fromfunction

* Added dpnp.fromiter

* Added dpnp.loadtxt

* Aligned array creation page with numpy content

* Alligned usm_type description across all aray creation functions

* Change usm_type to None default value for function with input array as argument

* Updated to use dpnp.check_limitations

* Rollbacked changed default usm_type for linspace, logspace and geomspace

* Added handling of usm_type=None to array creation functions fc317cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpnp array creations should document device, sycl_queue, usm_type keywords in docstrings
2 participants