Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thrid party testing f/w #1754

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 20, 2024

The testing framework of third party tests were not updated for a long time. Now it might be difficult to align the tests without alignments in the base functionality, since many internal methods were rewritten or changed.

The PR attempts to update the base testing framework to speed up future development.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@antonwolfy antonwolfy force-pushed the update_third-party-testing-fw branch from f6fd9bc to 1ad55f1 Compare March 21, 2024 12:50
@antonwolfy antonwolfy marked this pull request as ready for review March 21, 2024 12:51
@vlad-perevezentsev vlad-perevezentsev self-requested a review March 22, 2024 10:04
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 1b58244 into master Mar 22, 2024
45 checks passed
@antonwolfy antonwolfy deleted the update_third-party-testing-fw branch March 22, 2024 11:47
github-actions bot added a commit that referenced this pull request Mar 22, 2024
* Update thrid party testing f/w

* Updated names of skipped tests based on new f/w rules

* Replaced removed dpctl.get_current_device_type() call

* Applied review comments 1b58244
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Mar 22, 2024
* Update thrid party testing f/w

* Updated names of skipped tests based on new f/w rules

* Replaced removed dpctl.get_current_device_type() call

* Applied review comments 1b58244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants