-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update thrid party testing f/w #1754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
antonwolfy
force-pushed
the
update_third-party-testing-fw
branch
from
March 21, 2024 12:50
f6fd9bc
to
1ad55f1
Compare
vlad-perevezentsev
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Mar 22, 2024
* Update thrid party testing f/w * Updated names of skipped tests based on new f/w rules * Replaced removed dpctl.get_current_device_type() call * Applied review comments 1b58244
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Mar 22, 2024
* Update thrid party testing f/w * Updated names of skipped tests based on new f/w rules * Replaced removed dpctl.get_current_device_type() call * Applied review comments 1b58244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing framework of third party tests were not updated for a long time. Now it might be difficult to align the tests without alignments in the base functionality, since many internal methods were rewritten or changed.
The PR attempts to update the base testing framework to speed up future development.