Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.nancumsum() through dpnp.cumsum call #1781

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Implement dpnp.nancumsum() through dpnp.cumsum call #1781

merged 4 commits into from
Apr 10, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 9, 2024 •
edited
Loading

The PR proposes to implement dpnp.nancumsum() through existing call of dpnp.cumsum function.
The tests relating to NaN-like functions are decoupled to a new test scope tests/test_nanfunctions.py

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana reviewed Apr 10, 2024
View reviewed changes
tests/test_nanfunctions.py Outdated Show resolved Hide resolved
vtavana
vtavana reviewed Apr 10, 2024
View reviewed changes
tests/test_nanfunctions.py Outdated Show resolved Hide resolved
tests/test_nanfunctions.py Outdated Show resolved Hide resolved
vtavana
vtavana approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 506d7a7 into master Apr 10, 2024
55 of 56 checks passed
@antonwolfy antonwolfy deleted the implement-nancumsum branch April 10, 2024 14:33
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 10, 2024
@github-actions
Implement dpnp.nancumsum() through dpnp.cumsum call (IntelPython#…
7445ddf 
…1781)

* Implement dpnp.nancumsum() through existing calls

* Enabled strict dtype check due to recent changes in dpnp.sum()

* FFT tests still require check_only_type_kind=True 506d7a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana