Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.histogram_bin_edges #1823

Merged
merged 7 commits into from
May 15, 2024
Merged

Implement dpnp.histogram_bin_edges #1823

merged 7 commits into from
May 15, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 13, 2024 •
edited
Loading

This PR implements dpnp.histogram_bin_edges function. All the required tests are added to verify the new functionality.
The function leverages on existing internal functions previously used in implementation of dpnp.histogram.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev reviewed May 15, 2024
View reviewed changes
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
@vlad-perevezentsev vlad-perevezentsev self-requested a review May 15, 2024 15:46
vlad-perevezentsev
vlad-perevezentsev approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy for implementing this. Looks good

@antonwolfy antonwolfy merged commit 948c3ce into master May 15, 2024
56 checks passed
@antonwolfy antonwolfy deleted the impl_histogram_bin_edges branch May 15, 2024 16:35
github-actions bot added a commit that referenced this pull request May 15, 2024
@github-actions
Implement dpnp.histogram_bin_edges (#1823)
c679ba6 
* Implement dpnp.histogram_bin_edges

* Properly updated usm_type relating test

* Apply review comment

* Removed passing sycl_queue keyword in the example

* Describe density=None use case in histogram 948c3ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev