Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dpnp.linalg.eigh() hang with complex dtypes on CPU #1832

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix dpnp.linalg.eigh() hang with complex dtypes on CPU #1832

merged 2 commits into from
May 20, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests adding a temporary w/a as waiting also for each host task before calling oneapi::mkl::lapack::heevd to avoid a deadlock for batch implementation of dpnp.linalg.eigh for complex data types on CPU with the prerelease version of MKL.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit 31f9405 into master May 20, 2024
40 of 47 checks passed
@antonwolfy antonwolfy deleted the fix_heevd_hang_cpu branch May 20, 2024 10:32
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Wait for each host_task before calling _heevd (#1832)
f6306fa 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 31f9405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy