-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of falling back on numpy in dpnp.put
#1838
Conversation
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
@antonwolfy |
|
dpnp.put
dpnp.put
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @antonwolfy
The PR proposes to get rid of
call_origin
(i.e. falling back on numpy) indpnp.put
function.Additionally, the safe casting of indices to
intp
dtype is added to the implementation.The tests are updated to remove temporary workaround of dpctl#1382, because it has been resolved.
Also they are separated to
class TestPut
and extended with more test scenarios.