Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.digitize() #1847

Merged
merged 14 commits into from
May 23, 2024
Merged

Implement dpnp.digitize() #1847

merged 14 commits into from
May 23, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests adding an implementation of dpnp.digitize() using dpnp.searchsorted() including support for all function arguments.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed May 22, 2024
View reviewed changes
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_histogram.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed May 22, 2024
View reviewed changes
tests/test_histogram.py Show resolved Hide resolved
tests/test_histogram.py Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev . It's really nice to have one more function done in so short time, which will be included into the release.

@vlad-perevezentsev vlad-perevezentsev mentioned this pull request May 23, 2024
Closed
@antonwolfy antonwolfy merged commit 6c41c4f into master May 23, 2024
50 of 56 checks passed
@antonwolfy antonwolfy deleted the impl_digitize branch May 23, 2024 12:23
@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy