Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve gh-1871 #1872

Merged
merged 5 commits into from
Jun 15, 2024
Merged

resolve gh-1871 #1872

merged 5 commits into from
Jun 15, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 7, 2024

This PR resolved issue #1871.

It also improves the performance for some special cases.

>>> import  dpnp
>>> size = 4096
>>> device="gpu"
>>> a = dpnp.ones((size, size), order="F", device=device)
>>> b = dpnp.ones((size, size), order="F", device=device)
>>> %timeit dpnp.matmul(a, b) 

New implementation
Iris Xe: 142 ms ± 6.03 ms 
Intel Core: 1.81 s ± 383 ms 

Old dpnp
Iris Xe: 156 ms ± 3.38 ms 
Intel Core: 2.07 s ± 69.2 ms 
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review June 7, 2024 20:27
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Outdated Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM!

@antonwolfy antonwolfy merged commit fe93c05 into master Jun 15, 2024
47 of 56 checks passed
@antonwolfy antonwolfy deleted the result_array_matmul branch June 15, 2024 10:03
github-actions bot added a commit that referenced this pull request Jun 15, 2024
* update returned result when out is defined with order F

* address comments

* add test for out keyword in einsum

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> fe93c05
vtavana added a commit that referenced this pull request Jun 16, 2024
* update returned result when out is defined with order F

* address comments

* add test for out keyword in einsum

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants