Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dpnp.fft.fftshift and dpnp.fft.ifftshift #1900

Merged
merged 8 commits into from
Jul 15, 2024
Merged

implement dpnp.fft.fftshift and dpnp.fft.ifftshift #1900

merged 8 commits into from
Jul 15, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 26, 2024

In this PR, dpnp.fft.fftshift and dpnp.fft.ifftshift are implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jun 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/1900/index.html

@vtavana vtavana marked this pull request as ready for review June 26, 2024 17:33
antonwolfy
antonwolfy reviewed Jul 15, 2024
View reviewed changes
dpnp/fft/dpnp_iface_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_iface_fft.py Outdated Show resolved Hide resolved
vtavana and others added 2 commits July 15, 2024 08:28
@vtavana @antonwolfy
Apply suggestions from code review
43ef50f 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@vtavana
Merge branch 'master' into fft_shift
6175565
antonwolfy
antonwolfy approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy merged commit 65e33c9 into master Jul 15, 2024
33 of 37 checks passed
@antonwolfy antonwolfy deleted the fft_shift branch July 15, 2024 15:38
github-actions bot added a commit that referenced this pull request Jul 15, 2024
@github-actions
implement dpnp.fft.fftshift and dpnp.fft.ifftshift (#1900)
569d88c 
* implement fftshift

* remove old implementation

* fix alphabetic order

* add CFD tests

* Apply suggestions from code review

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 65e33c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy