Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp.extract implementation to get rid of limitations for input arguments #1906

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Update dpnp.extract implementation to get rid of limitations for input arguments #1906

merged 7 commits into from
Jul 4, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 3, 2024 •
edited
Loading

The PR proposes to extend implementation of dpnp.extract and to align the behavior with NumPy.

Docstrings are updated with missing information about input arguments.
The tests are updated to cover more use cases and to include compute follows data scenario.

Additionally, the implementation of dpnp.extract is now properly handling async execution model from dpctl.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

npolina4
npolina4 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@npolina4 npolina4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit 740b08b into master Jul 4, 2024
23 of 39 checks passed
@antonwolfy antonwolfy deleted the impl-extract branch July 4, 2024 12:19
github-actions bot added a commit that referenced this pull request Jul 4, 2024
@github-actions
Update dpnp.extract implementation to get rid of limitations for in…
aea0ffc 
…put arguments (#1906)

* Remove limitations from dpnp.extract implementation

* Add more tests

* Tune rtol and atol for a histogram test, since might fail on Windows

* Fix a typo in description

* Add test to cover condition as list 740b08b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @npolina4