Resolve compilation issues with new DPC++ 2025.0 compiler #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
vlad-perevezentsev,
ekomarova,
npolina4 and
vtavana
ekomarova
approved these changes
Jul 6, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 6, 2024
* CL/sycl.hpp is deprecated, use sycl/sycl.hpp * Explicitly include complex header * Use explicit type casting in a function from sycl namespace * Use proper sycl namespace * Use multi_ptr instead of raw pointer in sycl::modf * Applied pre-commit hook for clang-format e6cf9d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPC++ 2025.0 compiler introduces a number of non-backward compatible changes. And these changes broke build for
dpnp.That PR adopts dpnp towards affected DPC++ 2025.0 changes:
CL/sycl.hppis deprecated, and so usesycl/sycl.hppmulti_ptrinstead of raw-pointers for SYCL math functions overloadsThe applied code changes implemented in a favor to work with DPC++ 2024.2 as well.
The changes has to be ported to
dev-milestonebranch once the PR is merged. It's required to unblock the internal CI flow where DPC++ 2025.0 compiler is only available for now.