Implement syevd_batch and heevd_batch
#1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
antonwolfy
reviewed
Jul 23, 2024
vtavana
reviewed
Jul 23, 2024
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Jul 25, 2024
antonwolfy
reviewed
Jul 25, 2024
antonwolfy
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Thank you @vlad-perevezentsev . It's really nice changes which can be replicated to other batch functions and which help to get rid of limitations we previously had there.
github-actions bot
added a commit
that referenced
this pull request
Jul 26, 2024
* Implement syevd_batch and heevd_batch * Move include dpctl type_utils header to sourse files * Add memory alocation check for scratchpad * Add more checks for scratchpad_size * Move includes * Allocate memory for w with expected shape * Applied review comments * Add common_evd_checks to reduce dublicate code * Remove host_task_events from syevd and heevd * Applied review comments * Use init_evd_dispatch_table instead of init_evd_batch_dispatch_table * Move init_evd_dispatch_table to evd_common_utils.hpp * Add helper function check_zeros_shape * Implement alloc_scratchpad function to evd_batch_common.hpp * Make round_up_mult as inline * Add comment for check_zeros_shape * Make alloc_scratchpad as inline aa534f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a duplicate and continues the work of #1867 . Due to the change in
syevd/heevdfunction interface #1891 this PR is a quick way to avoid conflicts during rebasing.This PR suggests adding
syevd_batchandheevd_batchimplementation as a separate function and provide iteration of the batch array within it to avoid allocation of each 2D array before callingsyevdandheevdto improve performance and avoid serialization of all host tasks in the queue in MKL call;