Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of dpnp.nextafter function #1938

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Add implementation of dpnp.nextafter function #1938

merged 7 commits into from
Jul 23, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 19, 2024 •
edited
Loading

The PR proposes to add implementation of dpnp.nextafter function which is missing now.

There is new VM functions are added to use nextafter from OneMKL library where it's possible.
In other places the PR propose to leverage on new binary universal function _nextafter function from dpctl implemented in dpctl-1730.

The all affected tests are updated to cover different use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 19, 2024
@antonwolfy antonwolfy mentioned this pull request Jul 19, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 21, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 22, 2024 13:08
vtavana
vtavana reviewed Jul 23, 2024
View reviewed changes
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_floating.py Outdated Show resolved Hide resolved
dpnp/backend/extensions/vm/nextafter.cpp Outdated Show resolved Hide resolved
vtavana
vtavana approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 7b016d9 into master Jul 23, 2024
39 of 45 checks passed
@antonwolfy antonwolfy deleted the impl_nextafter branch July 23, 2024 22:34
github-actions bot added a commit that referenced this pull request Jul 23, 2024
@github-actions
Add implementation of dpnp.nextafter function (#1938)
e834119 
* Implement dpnp.nextafter

* Add MKL extension for nextafter

* Applied pre-commit hook

* Applied review comments 7b016d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana