Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage on dpctl.tensor implementation in dpnp.count_nonzero #1962

Merged
merged 5 commits into from
Aug 4, 2024
Merged

Leverage on dpctl.tensor implementation in dpnp.count_nonzero #1962

merged 5 commits into from
Aug 4, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 2, 2024 •
edited
Loading

The PR proposes to leverage on dpctl.tensor implementation in dpnp.count_nonzero function.
Additional missing description of input parameters is added.

Also existing helper dpnp.get_result_array function is extended to allow usm_ndarray as input array.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 2, 2024
@antonwolfy antonwolfy changed the title Leverage on dpctl.tensor implementation of count_nonzero Leverage on dpctl.tensor implementation in dpnp.count_nonzero Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review August 2, 2024 09:49
vlad-perevezentsev
vlad-perevezentsev approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit cb56101 into master Aug 4, 2024
45 checks passed
@antonwolfy antonwolfy deleted the dpctl-count_nonzero branch August 4, 2024 07:08
github-actions bot added a commit that referenced this pull request Aug 4, 2024
@github-actions
Leverage on dpctl.tensor implementation in dpnp.count_nonzero (#1962)
b0d1ef6 
* Leverage on dpctl.tensor implementation of count_nonzero

* Extend dpnp.get_result_array() to accept dpt.usm_ndarray

* Updated dpnp.mean() per review comment

* Add more dpnp tests to cover different use cases cb56101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev